New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding transports before defaults #272

Merged

pkqk merged 1 commit into movio:main from benzolium:allow-transport-override

Jul 16, 2024

Contributor

benzolium commented Jun 13, 2024

As I mentioned in #80 (comment), one could not override default transports now.

With this small change, one could set up own transport, because first transport get's selected:
https://github.com/99designs/gqlgen/blob/fb67b709af4f0c5ba6eff8222c728b076a6eb09b/graphql/handler/server.go#L98

It will allow users, for example, to introduce batching with a bramble plugin, as I also mentioned in comment: #80 (comment).


          allow users to override transport

09c13b6

benzolium requested a review from a team as a code owner

June 13, 2024 19:31

pkqk approved these changes

View reviewed changes

Member

pkqk left a comment

This looks good, I couldn't find any plugins that depend on the order for that hook.

pkqk changed the title ~~allow users to override transport~~ Allow adding transports before defaults

pkqk merged commit f24f90e into movio:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet